From: Olivier Marin <dkr+ml.git@free.fr>
Date: Thu, 24 Jul 2008 16:59:15 GMT
Subject: Re: [PATCH 1/9] builtin-verify-tag.c: use parse_options()
Message-ID: <4888B4E3.9000504@free.fr>
In-Reply-To: <1216849332-26813-2-git-send-email-barra_cuda@katamail.com>

Michele Ballabio a écrit :
> 
>  	if (argc == 1)
> -		usage(builtin_verify_tag_usage);
> +		usage_with_options(builtin_verify_tag_usage, options);

It seems this is broken since the C rewrite: "git verify-tag -v" just do
nothing instead of printing usage message.

Moving the if() after parse_options() call with s/argc == 1/argc == 0/
should do the trick.

> -	if (!strcmp(argv[i], "-v") || !strcmp(argv[i], "--verbose")) {
> -		verbose = 1;
> -		i++;
> -	}
> +	argc = parse_options(argc, argv, options, builtin_verify_tag_usage, 0);

Olivier.