From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 22 Jul 2008 08:29:11 GMT
Subject: Re: [PATCH 2/2] spawn pager via run_command interface
Message-ID: <48859A57.9090302@viscovery.net>
In-Reply-To: <20080722075035.GC3999@sigill.intra.peff.net>

Jeff King schrieb:
> On Tue, Jul 22, 2008 at 09:48:09AM +0200, Johannes Sixt wrote:
> 
>> BTW, you could remove the #ifndef __MINGW32__ around both the definition
>> and the use of pager_preexec. We have everything on mingw to compile and
>> link this function.
> 
> Ah, OK. I left it around the function because I was worried about fd_set
> needing some magic for compilation.

I do not expect you to know the intricacies of the mingw port. Hence,
staying on the safe side, like you did, is of course highly appreciated.

> However, it still won't be _used_ on Windows, because there is no
> opportunity to use the pre-exec callback (it is silently ignored).

That's fine.

-- Hannes