From: Johannes Sixt Date: Tue, 22 Jul 2008 07:17:16 GMT Subject: Re: [PATCH] Fix update-index --refresh for submodules if stat(2) returns st_size 0 Message-ID: <4885897C.8010401@viscovery.net> In-Reply-To: <20080721173511.GB5387@steel.home> Alex Riesen schrieb: > Can MSys folks please try it? I noticed it when the test > t2103-update-index-ignore-missing.sh (the 5th case) started failing. I tested it. mingw.git does suffer from the problem, and this fixes it. But! > + if ((changed & DATA_CHANGED) && (ce->ce_size != 0 || S_ISGITLINK(ce->ce_mode))) Does this mean that ce->ce_size is non-zero for gitlinks, at least on Unix? Is this value useful in anyway? I don't think so. Then it shouldn't be a random value that lstat() happens to return. -- Hannes