From: Lea Wiemann <lewiemann@gmail.com>
Date: Fri, 18 Jul 2008 16:51:47 GMT
Subject: Re: [PATCH 2/3] add new Git::Repo API
Message-ID: <4880CA23.40003@gmail.com>
In-Reply-To: <200807181735.15278.jnareb@gmail.com>

Jakub Narebski wrote:
> Besides if decoding is done in Perl API, we can convert it simply
> to Perl internal form (which, IIUC, in modern Perl is UTF-8 and
> marked as such).

FWIW, Perl strings actually contain non-encoded Unicode code points.
IOW, they're not byte strings.

> Still I think that putting cmd_output and other in Git::Repo
> is not a good API.

Yup; that's why I'm underscore-prefixing it (and taking it out of the
man page) for the next version of this patch.

> By the way, would you prefer if I commented on 3/3 patch as it is now,
> [...] or would you rather I wait for next round (next version) of patches?

I suggest you wait for the next version of the patch series, which I'll
post in a few hours.  There are quite a few changes; I'll list them in
the parent message for the series.

-- Lea