From: Lukas Sandström Date: Thu, 10 Jul 2008 21:41:33 GMT Subject: [PATCH] git-mailinfo: Fix getting the subject from the body Message-ID: <4876820D.4070806@etek.chalmers.se> "Subject: " isn't in the static array "header", and thus memcmp("Subject: ", header[i], 7) will never match. Signed-off-by: Lukas Sandström --- This has been broken since 2007-03-12, with commit 87ab799234639c26ea10de74782fa511cb3ca606 so it might not be very important. builtin-mailinfo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c index 962aa34..2d1520f 100644 --- a/builtin-mailinfo.c +++ b/builtin-mailinfo.c @@ -334,7 +334,7 @@ static int check_header(char *line, unsigned linesize, char **hdr_data, int over return 1; if (!memcmp("[PATCH]", line, 7) && isspace(line[7])) { for (i = 0; header[i]; i++) { - if (!memcmp("Subject: ", header[i], 9)) { + if (!memcmp("Subject", header[i], 7)) { if (! handle_header(line, hdr_data[i], 0)) { return 1; } -- 1.5.4.5