From: Johannes Sixt Date: Wed, 25 Jun 2008 10:49:10 GMT Subject: Re: [PATCH] git-gui: Don't select the wrong file if the last listed file is staged. Message-ID: <486222A6.70205@viscovery.net> In-Reply-To: <20080625103650.GA20492@toroid.org> Abhijit Menon-Sen schrieb: > Johannes Sixt noticed that if the last file in the list was staged, my > earlier patch would display the diff for the penultimate file, but show > the file _before_ that as being selected. > > This was due to my misunderstanding the lno argument to show_diff. > > This patch fixes the problem: lno is not decremented in the special case > to handle the last item in the list (though we still need to use $lno-1 > to find the right path for the next diff). Thanks. It works here, too: Tested-by: Johannes Sixt -- Hannes