From: Olivier Marin <dkr+ml.git@free.fr>
Date: Wed, 11 Jun 2008 18:36:45 GMT
Subject: Re: [PATCH] git-rebase -i: have an option for amending the commit message only.
Message-ID: <48501B3D.3000405@free.fr>
In-Reply-To: <1213196490-7762-1-git-send-email-madcoder@debian.org>

Hi,

I like the feature and I have just two comments:

Pierre Habouzit a écrit :
>
> +	comment|c)

Is "comment" the right name? I'm not sure, I just ask.

> +		comment_for_reflog comment
> +
> +		mark_action_done
> +		pick_one $sha1 ||
> +			die_with_patch $sha1 "Could not apply $sha1... $rest"
> +		output git commit --no-verify --amend -e -C HEAD

It does not work with an editor that opens in the current terminal
like vi. Just remove "output" should fix the problem, I think.

Olivier.