From: Marek Zawirski <marek.zawirski@gmail.com>
Date: Sat, 07 Jun 2008 00:06:45 GMT
Subject: Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter
Message-ID: <4849D115.5030602@gmail.com>
In-Reply-To: <200806061524.04140.robin.rosenberg@dewire.com>

On Fri, Jun 6, 2008 at 3:24 PM, Robin Rosenberg 
<robin.rosenberg@dewire.com> wrote:
> A well defined set of enhancements with only minor nitpicks (in separate mails)

Nice to hear. I'll send v2 of these 2 patches (04 and 09) in a moment. 
With a slightly less place for nitpicks, I hope.

>  I'm somewhat reluctant to reformatting patches though. 

Well, so should I remove these reformatting patches from series? (oouch!)

Actually, when I ran into formatting problem, Shawn suggested that I may 
format PackFile as he was also touching this file - I much appreciated 
this idea. PackIndex* formatting is however my own invention.

So you assume that Eclipse 3.4 will just force us to submit new patches
with specified formatting, but keep old lines formatting untouched, am I
right?
Isn't it somewhat annoying that formatting is inconsistent through
project (especially line width in some places)? And that I almost have
to block formatting shortcut to stop my pre-save/pre-commit habit?;)

Thanks,
-- 
Marek Zawirski / zawir
marek.zawirski@gmail.com