From: Olivier Marin <dkr+ml.git@free.fr>
Date: Fri, 06 Jun 2008 10:02:34 GMT
Subject: Re: [PATCH v3 2/2] git-add: introduce --edit (to edit the diff vs. the index)
Message-ID: <48490B3A.4020900@free.fr>
In-Reply-To: <alpine.DEB.1.00.0806060007000.21190@racer>

Johannes Schindelin a écrit :
>  
> +int edit_patch(int argc, const char **argv, const char *prefix)
> +{

[...]

> +	if (!result)
> +		result = run_command(&child);
> +	free(child.argv);
> +
> +	launch_editor(file, NULL, NULL);

Here, it does not launch the editor I defined with core.editor because you
call edit_patch() before calling git_config() in cmd_add().

Also, wouldn't be better to have the edit_patch stuff in add--interactive
instead ? It seems to work the same way than the --patch option.

Just my thoughts.

Olivier.