From: Lea Wiemann <lewiemann@gmail.com>
Date: Tue, 03 Jun 2008 11:42:58 GMT
Subject: Re: [PATCH] Avoid errors from git-rev-parse in gitweb blame
Message-ID: <48452E42.9080305@gmail.com>
In-Reply-To: <1212489977-26822-1-git-send-email-rgarciasuarez@gmail.com>

Rafael Garcia-Suarez wrote:
> git-rev-parse will abort with an error when passed a non-existent
> revision spec, [...]
>
> -		open (my $dd, "-|", git_cmd(), "rev-parse", "$full_rev^")
> +		open (my $dd, "-|", git_cmd(), "rev-parse", '--revs-only', "$full_rev^")

This is no formal objection, but it would be nice if you could at the 
same time add a comment to the code that explains this -- like "do not 
fail [or 'barf on stderr'] if there is no parent revision".  Makes it 
easier to change it later, since "--revs-only" is not particularly 
obvious. :)

-- Lea