From: Florian Köberle <florianskarten@web.de>
Date: Fri, 23 May 2008 15:46:42 GMT
Subject: Re: [JGIT PATCH v2 04/24] Added path related constats to Constats class.
Message-ID: <4836E6E2.20406@web.de>
In-Reply-To: <20080512235431.GY29038@spearce.org>

Shawn O. Pearce wrote:
> Florian Koeberle <florianskarten@web.de> wrote:
>> @@ -171,6 +171,26 @@ public final class Constants {
>>  	public static String REMOTES_PREFIX = "refs/remotes";
>>  
>>  	/**
>> +	 * The name of the repository directory in the project directory.
>> +	 */
>> +	public static final String REPOSITORY_DIRECTORY_NAME = ".git";
> 
> What is a project directory?
I will add a sentence describing what I meant with project directory here.



>> +	/**
>> +	 * Contains the name of the HEAD file in the repository directory.
>> +	 */
>> +	public static final String HEAD_FILE_NAME = "HEAD";
> 
> Isn't this already declared as just HEAD?  Lets not duplicate
> constants if we can avoid it, especially when they are in the
> same class.
>
current HEAD constant definition:
 > 	/** Special name for the "HEAD" symbolic-ref. */
 >	public static final String HEAD = "HEAD";
I didn't expect that this constant is a file name.

Looks like the constant is used in the same way I do, so It makes sense 
to use the existing HEAD constant.