From: Paolo Bonzini <bonzini@gnu.org>
Date: Wed, 14 May 2008 09:33:50 GMT
Subject: Re: [PATCH 4/4] filter-branch: fix variable export logic
Message-ID: <482AB1FE.6030009@gnu.org>
In-Reply-To: <20080514045717.GA16592@sigill.intra.peff.net>


>   if test -n "$ORIG_GIT_DIR"
>   then
>     ...
>   fi
> 
> would be even clearer, though I'm not sure if "-n" has any portability
> concerns.

It has not.  Some autoconf scripts do

   if test "x$ORIG_GIT_DIR" != x; then
     ...
   fi

(and similarly for -z) but that's being phased out.

Paolo