From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 17 Apr 2020 01:53:51 GMT
Subject: Re: [PATCH v3 2/2] log: add log.excludeDecoration config option
Message-ID: <481d4e05-c6f8-0554-e8f6-04562d316c4c@gmail.com>
In-Reply-To: <xmqqftd3z4sa.fsf@gitster.c.googlers.com>

On 4/16/2020 2:03 PM, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
>>>  	if (include_patterns && include_patterns->nr) {
>>> -		int found = 0;
>>>  		for_each_string_list_item(item, include_patterns) {
>>>  			if (match_ref_pattern(refname, item)) {
>>> -				found = 1;
>>> -				break;
>>> +				return 1;
>>>  			}
>>
>> Micronit.  
>>
>> Let's mimick the early return in the loop above (for command line
>> excludes) and below (for configured excludes), each of which is just
>> a single "return" statement in a block without {braces} around.
> 
> ... heh, it seems that the nit is mine in the suggested alternative
> upthread.  Let me amend while queuing.

Shame on me for not noticing. Thanks for the close look!

-Stolee