From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 05 May 2008 07:03:49 GMT
Subject: Re: [PATCH v3 00/10] Fix git's test suite to pass when the path contains spaces
Message-ID: <481EB155.6050501@viscovery.net>
In-Reply-To: <1209879480-16910-1-git-send-email-bdonlan@fushizen.net>

Bryan Donlan schrieb:
> This patch series fixes bugs in git and git's testsuite to allow all tests
> to pass when the working directory contains whitespace and/or shell
> metacharacters.

Thanks a lot, it's appreciated.

> Bryan Donlan (10):
>   git-rebase.sh: Fix --merge --abort failures when path contains
>     whitespace
>   config.c: Escape backslashes in section names properly
>   git-send-email.perl: Handle shell metacharacters in $EDITOR properly
>   test-lib.sh: Add a test_set_editor function to safely set $VISUAL
>   Use test_set_editor in t9001-send-email.sh
>   test-lib.sh: Fix some missing path quoting
>   lib-git-svn.sh: Fix quoting issues with paths containing shell
>     metacharacters
>   Don't use the export NAME=value form in the test scripts.
>   Fix tests breaking when checkout path contains shell metacharacters
>   Rename the test trash directory to contain spaces.

The last patch breaks t9400-git-cvsserver-server.sh on my system:

* expecting success: cat request-anonymous | git-cvsserver --strict-paths
pserver $SERVERDIR >log 2>&1 &&
   sed -ne \$p log | grep "^I LOVE YOU$"
* FAIL 9: req_Root (strict paths)
        cat request-anonymous | git-cvsserver --strict-paths pserver
$SERVERDIR >log 2>&1 &&
           sed -ne \$p log | grep "^I LOVE YOU$"

D-Quoting $SERVERDIR helps. ;)

Please post an incremental diff when you resend it. Feel free to add:

Tested-by: Johannes Sixt <johannes.sixt@telecom.at>

-- Hannes