From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 09 Apr 2008 07:01:31 GMT
Subject: Re: [PATCH 7/8] Use test_set_editor in t9001-send-email.sh
Message-ID: <47FC69CB.1080400@viscovery.net>
In-Reply-To: <1207704604-30393-7-git-send-email-bdonlan@fushizen.net>

Bryan Donlan schrieb:
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 030f66c..0a65785 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -144,10 +144,7 @@ test_expect_success 'setup fake editor' '
>  	chmod +x fake-editor
>  '
>  
> -FAKE_EDITOR="$(pwd)/fake-editor"
> -export FAKE_EDITOR
> -GIT_EDITOR='"$FAKE_EDITOR"'
> -export GIT_EDITOR
> +test_set_editor "$(pwd)/fake-editor"
>  
>  test_expect_success '--compose works' '
>  	clean_fake_sendmail &&

I'd squash this into 5/8 or 8/8. Dunno.

-- Hannes