From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 13 Mar 2008 14:15:02 GMT
Subject: Re: [PATCH v2 3/4] builtin-status: configurable submodule summary size
Message-ID: <47D936E6.10107@viscovery.net>
In-Reply-To: <1205416085-23431-4-git-send-email-pkufranky@gmail.com>

Ping Yin schrieb:
> +	if (wt_status_submodule_summary == 0) return;

Style:
	if (!wt_status_submodule_summary)
		return;

>  	struct child_process sm_summary;
> +	char summary_limit[64];
> +	sprintf(summary_limit, "%d", wt_status_submodule_summary);
>  	const char *argv[] = {

Declaration after statement. That's not portable.

-- Hannes