From: Johannes Sixt Date: Wed, 09 Jan 2008 10:01:04 GMT Subject: Re: [PATCH] Simplified the invocation of command action in submodule Message-ID: <47849B60.2060000@viscovery.net> In-Reply-To: <7bfdc29a0801090151k22d3cd5aqedb0d4860868d4d9@mail.gmail.com> Imran M Yousuf schrieb: > On Jan 9, 2008 2:59 PM, Johannes Sixt wrote: >> - Previously, passing --cached to add, init, or update was an error, now >> it is not. > > The usage statement and this behaviour is rather contradicting. The > usage says that --cached can be used with all commands; so I am not > sure whether using --cached with add should be an error or not. IMHO, > if the previous implementation was right than the USAGE has to be > changed, and if the previous implementation was incorrect, than if the > default command is set to status than current implementation is right. I prefer that the usage statement lists one line per sub-command with the flags that apply only to the sub-command. IOW, a usage statement that suggests that a flag applies to all sub-commands when in reality it doesn't is bogus, IMHO. -- Hannes