From: Andreas Ericsson <ae@op5.se>
Date: Wed, 19 Dec 2007 08:55:20 GMT
Subject: Re: [PATCH] Add format-patch option --no-name-prefix.
Message-ID: <4768DC78.9010304@op5.se>
In-Reply-To: <4767F145.3030109@obry.net>

Pascal Obry wrote:
> Andreas Ericsson a écrit :
>> Pascal Obry wrote:
>>>      int thread = 0;
>>> +    int no_name_prefix = 0;
>> Do we not need no double negations, yes?
> 
> Not sure, looks clearer to use variable name corresponding to the option
> name to me...
> 

Perhaps. We just had this discussion on the list where multiple people had
extended a negative-sounding option. Personally I find it hard to parse
and bug-prone to write (and edit) something like

	if (!no_prefix)
		add_the_prefix();",

but perhaps that's just me.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231