From: A Large Angry SCM Date: Mon, 03 Dec 2007 23:10:36 GMT Subject: Re: make test failure with latest master Message-ID: <47548CEC.6010701@gmail.com> In-Reply-To: <20071203015954.GB8322@coredump.intra.peff.net> Jeff King wrote: > On Sun, Dec 02, 2007 at 11:41:10PM +0000, Johannes Schindelin wrote: > >>> Attached is the output of >>> >>> ./t9600-cvsimport.sh --verbose >/tmp/9600_out.txt 2>&1 >>> >> Unfortunately you attached the interesting part, so I cannot quote it >> here. Seems that your cvsps does not understand the "-A" option. So it >> looks like it is too old. [Ignoring gitte's declaration that the core of git is dependent on CVS] > Yes, the changelog indicates that -A was added in 2.1, and he is running > 2.0rc1. > > We can do something like this, though it feels a bit hack-ish and will > need updated for new cvsps versions (a less lazy or more clever shell > coder than me could do a nice >= version comparator). The patch "fixes" the issue for me. > -- >8 -- > t9600: require cvsps 2.1 to perform tests > > git-cvsimport won't run at all with less than cvsps 2.1, because it > lacks the -A flag. But there's no point in preventing people who have an > old cvsps from running the full testsuite. > > Signed-off-by: Jeff King Acked-by: A Large Angry SCM