From: Johannes Sixt Date: Fri, 30 Nov 2007 13:24:27 GMT Subject: Re: [PATCH] git-cvsserver runs hooks/post-receive Message-ID: <47500F0B.10300@viscovery.net> In-Reply-To: Michael Witten schrieb: > On 30 Nov 2007, at 7:03:15 AM, Johannes Schindelin wrote: >> On Thu, 29 Nov 2007, Michael Witten wrote: >>> How about turning git-cvsserver into a true middleman, so that it >>> constructs a 'temporary git working tree' and then does a real git-push >>> into the final git repository. >> >> That would yield a horrible performance. >> >> Would be opposed, if a regular cvsserver user, > > How come? > > git-cvsserver it seems already does just that! > The difference is that it puts objects in place > by hand, requiring the code to mirror hook calls > anyway. > > I'm simply proposing that the code be reworked, > so that cvs commits actually become git pushes, > so that all future changes to the pushing mechanism > are automatically handled. But in order push something, you must first have the commit in a repository. How would git-cvsserver do that? For example, by putting objects in place by hand. You gain nothing, except that it would push instead of call the hooks directly. -- Hannes