From: Dan Zwell <dzwell@gmail.com>
Date: Wed, 28 Nov 2007 07:58:59 GMT
Subject: Re: [PATCH] git-config --get-color: get configured color
Message-ID: <474D1FC3.50108@zwell.net>
In-Reply-To: <7vir3mal9u.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> +--get-color name default::
> +
> +	Find the color configured for `name` (e.g. `color.diff.new`) and
> +	output it as the ANSI color escape sequence to the standard
> +	output.  The optional `default` parameter is used if the
> +	configuration for `name` is missing.
Perhaps you could mention here that the second parameter is a normal 
string, not an ansi code? Just adding 'for example, "blue"' would 
probably help.

 > +RESET==$(git config --get-color "" "reset")

This is a typo, no?
+RESET=$(git config --get-color "" "reset")

Dan