From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 22 Nov 2007 07:29:29 GMT
Subject: Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()
Message-ID: <47452FD9.9000501@viscovery.net>
In-Reply-To: <7v63zv9fel.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> Hi,
>>
>> On Wed, 21 Nov 2007, Steffen Prohaska wrote:
>>
>>> We have a function set_git_dir().  So let's use it, instead of setting 
>>> the evironment directly.
>> Does this not have a fundamental issue?  When you call other git programs 
>> with run_command(), you _need_ GIT_DIR to be set, no?
> 
> It is much worse.  set_git_dir() does not just setenv() but does
> setup_git_env() as well.

I don't see what's wrong with that. Could you please explain?

-- Hannes