From: Andreas Ericsson <ae@op5.se>
Date: Fri, 09 Nov 2007 10:29:23 GMT
Subject: Re: [BUG] git-rebase fails when a commit message contains a diff
Message-ID: <47343683.7080904@op5.se>
In-Reply-To: <Pine.LNX.4.64.0711090225110.4362@racer.site>

Johannes Schindelin wrote:
>> +		case "$INTERACTIVE" in
>> +		t)
>> +			git_editor "$TODO" || die "Could not execute editor"
>> +			;;
>> +		esac
> 
> 
> Would that not be easier to read as
> 
> 		test t = "$INTERACTIVE" &&
> 			git_editor "$TODO" || die "Could not execute editor"
> 

Written like that, it would die every time $INTERACTIVE isn't "t". You'd need
curly braces around 

	git_editor "$TODO" || die "Could not execute editor"

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231