From: Andreas Ericsson Date: Sat, 03 Nov 2007 16:32:31 GMT Subject: Re: [PATCH] git-format-patch: Number patches when there are more than one Message-ID: <472CA29F.3090701@op5.se> In-Reply-To: <20071103160323.GA13284@glandium.org> Mike Hommey wrote: > On Sat, Nov 03, 2007 at 04:59:56PM +0100, Andreas Ericsson wrote: >> Mike Hommey wrote: >>> Automagically enable numbering if we output more than one patch. >>> Signed-off-by: Mike Hommey >>> --- >>> On Mon, Oct 22, 2007 at 10:44:12AM +0100, Johannes Schindelin wrote: >>>> Hi, >>>> >>>> On Sun, 21 Oct 2007, Andreas Ericsson wrote: >>>> >>>>> [PATCH 1/1] looks a bit silly, and automagically handling this in >>>>> git-format-patch makes some scripting around it a lot more pleasant. >>>> I think you should not use "-n" if you do not want to have the numbers. >>>> In circumstances as yours, where you can have patch series larger than >>>> one, I imagine that the "[PATCH 1/1]" bears an important information, >>>> which is not present in "[PATCH]": this patch series contains only one >>>> patch. >>>> >>>> IOW I do not like your patch: too much DWIDNS (Do What I Did NOT Say) for >>>> me. >>> How about the contrary ? >> Works for me. How does one turn it off? > > Does it make sense to turn it off ? > Sometimes, yes. I frequently gather several small fixes on a branch and then send all of them at once. They rarely depend on each other, and apply order is usually not important, so it doesn't make sense to order them. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231