From: Adam Roben <aroben@apple.com>
Date: Sun, 28 Oct 2007 06:19:52 GMT
Subject: Re: [PATCH 5/7] use only the $PATH for exec'ing git commands
Message-ID: <47242A08.3050503@apple.com>
In-Reply-To: <7vlk9nzrrv.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> Scott R Parish <srp@srparish.net> writes:
>
>   
>> diff --git a/exec_cmd.c b/exec_cmd.c
>> index 8b681d0..c228dbf 100644
>> --- a/exec_cmd.c
>> +++ b/exec_cmd.c
>> @@ -29,85 +29,68 @@ const char *git_exec_path(void)
>>  	return builtin_exec_path;
>>  }
>>  
>> +static void add_path(struct strbuf *out, const char *path)
>> +{
>> +	if (path && strlen(path)) {
>>     
>
> I wonder if s/strlen(path)/*path/ micro-optimization is worth
> doing.  Ideally, if built-in strlen() is used, the compiler
> should be clever enough to notice it, though...
>   

You could always just check path[0] instead of calling strlen.

-Adam