From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 23 Oct 2007 06:59:19 GMT
Subject: Re: [PATCH 1/9] Add tests for git cat-file
Message-ID: <471D9BC7.2070702@viscovery.net>
In-Reply-To: <1193118397-4696-2-git-send-email-aroben@apple.com>

Adam Roben schrieb:
> +    test_expect_success \
> +        "$type exists" \
> +        "git cat-file -e $hello_sha1"

You mean $sha1 here, right?

> +    test_expect_success \
> +        "Type of $type is correct" \
> +        "test $type = \"$(git cat-file -t $sha1)\""

This should escape the $(...) in all the tests. Like this:

         "test $type = \"\$(git cat-file -t $sha1)\""

> +test_expect_success \
> +    "Reach a blob from a tag pointing to it" \
> +    "test \"$hello_content\" = \"$(git cat-file blob $tag_sha1)\""

And use single quotes without escaping the double-quotes here.

-- Hannes