From: Andreas Ericsson Date: Sat, 13 Oct 2007 22:36:27 GMT Subject: Re: [PATCH] Fixing path quoting issues Message-ID: <4711486B.1050301@op5.se> In-Reply-To: <92879AC5-2927-439B-8EB0-AC20AAEE412E@steelskies.com> Jonathan del Strother wrote: > On 11 Oct 2007, at 07:19, Johannes Sixt wrote: > >>> - git-commit -F msg -m amending ." >>> + git-commit -F msg -m amending ." >> >> You fix whitespace... >> >>> test_expect_success \ >>> - "using message from other commit" \ >>> - "git-commit -C HEAD^ ." >>> + "using message from other commit" \ >>> + "git-commit -C HEAD^ ." >> >> ... and you break it. More of these follow. Don't do that, it makes >> patch review unnecessarily hard. > > > I'm just preparing to release this patch... was that "don't break > whitespace", or "don't try to fix whitespace in a patch that's has > nothing to do with whitespacing-fixing" ? > Both, I think ;-) > And while I'm here - tabs are preferred, are they? There seem to be a > mixture of tabs & 4 space indentation. 1 hard tab / level of indent, but use spaces for continuation alignment. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231