From: Dan Zwell <dzwell@gmail.com>
Date: Sat, 13 Oct 2007 20:03:29 GMT
Subject: Re: [PATCH] Color support added to git-add--interactive.
Message-ID: <47112491.8070309@gmail.com>
In-Reply-To: <20071013175127.GA3183@coredump.intra.peff.net>

Jeff King wrote:
> On Sat, Oct 13, 2007 at 01:27:45PM -0400, Jeff King wrote:
> 
> <snip> Though I am still concerned about the
> robustness of the re-parsing scheme.
> 
> -Peff
> 

The importance of the diff coloring pales in comparison to the prompt 
coloring. Diff coloring is useful, but prompt coloring is a basic 
usability concern (if people can't easily tell where a hunk begins, the 
tool becomes annoying). Perhaps we could split this into two patches, 
merging the first after a few small changes can be taken care of, while 
the second may need more discussion and testing. The coloring of the 
prompts is relatively low risk. It just needs to be modified to take 
color settings from .git/config. I was thinking that this might be the 
example that I would take settings from:

[color]
         add-interactive = auto
[color "add-interactive"]
         prompt = bold blue
         header = bold
         help = blue

For the sake of a unified interface, the "Stage this hunk?" prompt 
should be colored the same as the other prompts. I will give a bit of 
thought to the default colors, though it's important to avoid red and 
green (as those will look like diff output when the second patch is 
applied).

Also needed is some command line parsing so that "--color" can be 
specified on the command line (very small change), and all of this 
should be added to the documentation.

Obviously, the suggestions/fixes from other parts of this thread must be 
taken into account, as well. I can probably do all this tomorrow (and 
send low-risk/high-risk patches), unless someone takes it before me.

Dan