From: Andreas Ericsson <ae@op5.se>
Date: Thu, 04 Oct 2007 06:05:22 GMT
Subject: Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.
Message-ID: <470482A2.3080907@op5.se>
In-Reply-To: <Pine.LNX.4.64.0710040053380.28395@racer.site>

Johannes Schindelin wrote:
> Hi,
> 
> On Thu, 4 Oct 2007, Martin Waitz wrote:
> 
>> -		filemode = (!chmod(path, st1.st_mode ^ S_IXUSR) &&
>> +		/* test that new files are not created with X bit */
>> +		filemode = !(st1.st_mode & S_IXUSR);
>> +		/* test that we can modify the X bit */
>> +		filemode &= (!chmod(path, st1.st_mode ^ S_IXUSR) &&
> 
> Should that not be &&=?
> 

I should think |=

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231