From: Ping Yin <pkufranky@gmail.com>
Date: Sat, 12 Apr 2008 02:56:54 GMT
Subject: Re: [PATCH/RFC 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone
Message-ID: <46dff0320804111956p4eb3d9d7o3b404e1d93de5da2@mail.gmail.com>
In-Reply-To: <7vzls0qcmw.fsf@gitster.siamese.dyndns.org>

On Sat, Apr 12, 2008 at 5:56 AM, Junio C Hamano <junio@pobox.com> wrote:
> Ping Yin <pkufranky@gmail.com> writes:
>
>  > This behaviour change breaks t7400 which uses relative url './.subrepo'.
>  > However, this test originally doesn't mean to test relative url, so fix
>  > the url as '.subrepo'.
>
>  Hmmm.  Doesn't "foo" generally mean the same thing as "./foo" in the sense
>  both are relative to the current directory?

There is a little inconsistence in current logic

1. git submodule add ./foo will expand foo with remote.origin.url and
init an entry in .gitmodules as
"submodule.foo.url=$remoteoriginurl/foo"
2. git submodule update will not expand ./foo if  there is an entry
"submodule.foo.url=./foo"  in $GIT_DIR/config

I tend to add the url as is when "git submodule add", and then expand
the url when running "git submodule update". So this will result that
the second case expands './foo' as "$remoteoriginurl/foo" instead of
"foo"





-- 
Ping Yin