From: Ping Yin Date: Thu, 13 Mar 2008 18:01:06 GMT Subject: Re: [PATCH v2 2/4] builtin-status: submodule summary support Message-ID: <46dff0320803131101g62c16db2wf999c851672a8e0@mail.gmail.com> In-Reply-To: <47D935FE.8010107@viscovery.net> On Thu, Mar 13, 2008 at 10:11 PM, Johannes Sixt wrote: > Ping Yin schrieb: > > > wt_status_print_changed(s); > > + // must flush s->fp since following call will write to s->fp in a child process > > + fflush(s->fp); > > + wt_status_print_submodule_summary(s); > > wt_status_print_untracked(s); > > But then we don't need the fflush() here. Right? > You are right. diff --git a/wt-status.c b/wt-status.c index 2f47e36..468c14c 100644 --- a/wt-status.c +++ b/wt-status.c @@ -352,8 +352,6 @@ void wt_status_print(struct wt_status *s) } wt_status_print_changed(s); - // must flush s->fp since following call will write to s->fp in a child process - fflush(s->fp); wt_status_print_submodule_summary(s); wt_status_print_untracked(s) -- Ping Yin