From: Ping Yin <pkufranky@gmail.com>
Date: Fri, 07 Mar 2008 01:50:55 GMT
Subject: Re: [PATCH v3 3/4] git-submodule: New subcommand 'summary' (3) - limit summary size
Message-ID: <46dff0320803061750x70d059a2yaf1e5751e9c62150@mail.gmail.com>
In-Reply-To: <46dff0320803051824t75f39524uda9bc864a9fe4435@mail.gmail.com>

On Thu, Mar 6, 2008 at 10:24 AM, Ping Yin <pkufranky@gmail.com> wrote:
> On Thu, Mar 6, 2008 at 8:24 AM, Junio C Hamano <gitster@pobox.com> wrote:
>  > Ping Yin <pkufranky@gmail.com> writes:
>  >
>  >  > This patch teaches git-submodule an option '--summary-limit|-n <number>'
>  >  > to limit number of commits in total for the summary. Number 0 will disable
>  >  > summary and minus number means unlimted (the default).
>  >
>  >  I really doubt showing the bottom one specially makes sense.
>  >
>  >  Why not just read from
>  >
>  >         git log '--pretty=%m %h %s' --left-right --topo-order A...B
>  >
>  >  and show N top commits from each?

I doubt '%h' is useful and it may result in overlong message lines.
Is '--topo-order' expensive when only show top N commits?
I prefer to use

    git log --pretty='format:%m %s' --left-right --first-parent A...B

for modificated modules, and

   git log -1 --pretty='format:> %s' $sha1_dst
   git log -1 --pretty='format:< %s' $sha1_src

for added ( or blob -> submodule typechange) and deleted
( or submodule -> blob typechange) modules separately.




-- 
Ping Yin