From: Ping Yin Date: Sun, 02 Mar 2008 17:15:55 GMT Subject: Re: [PATCH 0/3] fix "diff --raw" on the work tree side Message-ID: <46dff0320803020915u565ce50eraa663f9e5a795b81@mail.gmail.com> In-Reply-To: <7v7igloxtu.fsf@gitster.siamese.dyndns.org> On 3/3/08, Junio C Hamano wrote: > "Ping Yin" writes: > > > On Sun, Mar 2, 2008 at 5:43 PM, Junio C Hamano wrote: > >> The second patch fixes the inconsistency between "git-diff --raw" and > >> "git-diff-{index,files} --raw" when they are used for submodules. > >> > >> The third one is a bit controversial and changes the semantics and > >> existing callers and won't be considered for 1.5.5. > >> > > Unfortunately, my submodule summary patch series will depend on > > git-diff or git-diff-index. So should i resend my improved patch only > > after the thrid one is applied? > > I do not think re-introducing the inconsistency like the third one does is > a palatable option. > > Wouldn't grabbing (cd $submodule && git rev-parse HEAD) yourself be more > portable across git before and after the bugfix of "git diff --raw"? > OK, i will parse it myself -- Ping Yin