From: Ping Yin Date: Sat, 01 Mar 2008 10:27:17 GMT Subject: Re: [PATCH v2 1/3] git-submodule: New subcommand 'summary' (1) - code framework Message-ID: <46dff0320803010227r5024d152g259a6a07a2441351@mail.gmail.com> In-Reply-To: <7vk5km7vir.fsf@gitster.siamese.dyndns.org> > > > > + grep '^:160000\|:[0-9]\+ 160000' | > > This looks troublesome. > > - [0-9] is obviously wrong and [0-7] is what you meant; > - \| and \+ are not BRE but GNU. > man grep says In basic regular expressions the metacharacters ?, +, {, |, (, and ) lose their special meaning; instead use the backslashed versions \?, \+, \{, \|, \(, and \). Doen't it mean that '\|' is BRE ? -- Ping Yin