From: Ping Yin <pkufranky@gmail.com>
Date: Sat, 12 Jan 2008 09:51:43 GMT
Subject: Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size
Message-ID: <46dff0320801120151s7959edddp1e1f8b506da79e4e@mail.gmail.com>
In-Reply-To: <7vabnbv3sb.fsf@gitster.siamese.dyndns.org>

On Jan 12, 2008 4:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Ping Yin <pkufranky@gmail.com> writes:
>
> > @@ -265,6 +267,10 @@ set_name_rev () {
> >  #
> >  modules_summary()
> >  {
> > +     summary_limit=${summary_limit:-1000000}
>
> Why a million?
Because i think a million is big enough. I'd better define a constant
for unlimited number.
>
> > +     summary_limit=$((summary_limit<0?1000000:summary_limit))
>
> This is doubly bashism.  Variables must be referenced with $,
> and $(( conditional ? iftrue : iffalse )) is not POSIX.
>
Ok, i'll fix this.


-- 
Ping Yin