From: Ping Yin <pkufranky@gmail.com>
Date: Sat, 12 Jan 2008 09:09:49 GMT
Subject: Re: [PATCH 1/5] git-submodule: New subcommand 'summary' (1) - code framework
Message-ID: <46dff0320801120109l5d69fcbancd68bbcec7f2455a@mail.gmail.com>
In-Reply-To: <7vmyrbv4ms.fsf@gitster.siamese.dyndns.org>

On Jan 12, 2008 4:18 PM, Junio C Hamano <gitster@pobox.com> wrote:

>
> Ping Yin <pkufranky@gmail.com> writes:
>
> > +     # get modified modules which have been checked out (i.e. cared by user)
> > +     modules=$(git diff $cache_option --raw $head -- "$@" |
> > +             grep '^:160000\|:000000 160000' |
> > +             while read mod_src mod_dst sha1_src sha1_dst status name
> > +             do
>
> You are listing paths that were already submodule in HEAD, or
> newly added submodule.  What about a path that used to be a blob
> but is being made into submodule with the next commit (i.e. RHS
> is 160000 but LHS is not 000000)?

Hmm, i had ignored such a case.
>
>
>
> > -case "$add,$init,$update,$status,$cached" in
> > -1,,,,)
> > +case "$add,$init,$update,$summary,$status,$cached" in
> > +1,,,,,)
> >       module_add "$@"
> >       ;;
>
> This is simply unsustainable.
>
> Please see the other thread with Imran M Yousuf regarding the
> command dispatcher.  I think that should be the first thing to
> fix before doing any change.
>
Ok, i will resend my patches after this fix


-- 
Ping Yin