From: Ping Yin Date: Wed, 21 Nov 2007 11:55:22 GMT Subject: Re: [PATCH] Fix start_command closing cmd->out/in regardless of cmd->close_out/in Message-ID: <46dff0320711210355icdbf634l258cf39c1582e8d4@mail.gmail.com> In-Reply-To: <7vmyt8gdzv.fsf@gitster.siamese.dyndns.org> On Nov 21, 2007 5:11 PM, Junio C Hamano wrote: > But I think an API definition that says "These fds are closed > after the call, so if you are going to use them, you can dup() > them beforehand" is equally valid, and I suspect that forgetting > to dup() is easier to detect than forgetting to close() --- you > will notice the former mistake immediately because your read and > write say "oops, nobody on the other end" but the latter mistake > will result in a hung process. And for that reason, I think it > can be called more "graceful". So ... > I don't konw the original API definition and havn't found any API deinition that clarifies the fds will be closed after start_command. However, when i see child_process.close_in/close_out, i thought start_command will not close the fds. I never said that start_command must not close fd. At least this behaviour of start_command makes child_process.close_in/close_out no sense. > > -- Ping Yin