From: Ping Yin Date: Thu, 15 Nov 2007 16:49:29 GMT Subject: Re: [PATCH] status&commit: Teach them to show submodule commit summary Message-ID: <46dff0320711150849l5b7dc6a3y6b625e45a3117d4f@mail.gmail.com> In-Reply-To: <8c5c35580711120947s246f192coa3796ac6541a28d7@mail.gmail.com> On Nov 13, 2007 1:47 AM, Lars Hjemli wrote: > On Nov 12, 2007 5:45 PM, Johannes Sixt wrote: > > Ping Yin schrieb: > > > On Nov 12, 2007 11:59 PM, Johannes Sixt wrote: > > > > > >> But at this time git-commit is about to be made a builtin, and since your > > >> implementation contains a lot of non-portable constructs ($'', >&) and a new > > >> dependency on awk (and, hence, has little chances of being accepted), I > > >> suggest that you stay tuned, and implement this in the forth-coming > > >> builtin-commit.c. > > > Implement this in shell scripts is just a piece of cake, but not so > > > easy in builtin-commit.c. > > > > I'm with you. But git-commit.sh is a dead horse, no matter how hard you beat it. > > > > BTW, maybe you can keep the log generation in a helper script, > > git-status--submodulesummary, and invoke that from builtin-commit.c. This > > way you get both: integration and ease of implementation. > > Sorry for repeating myself, but IMVHO this belong in git-submodule.sh: > It can be useful as a standalone command, we get all submodule-related > commands isolated in a single place, and builtin-commit.c can of > course exec git-submodule to get the summary. > OK. I'll reconsider it and reimplement it when i have time. -- Ping Yin