From: Eric Sunshine Date: Thu, 14 Apr 2022 06:51:07 GMT Subject: Re: [PATCH v3 17/29] CI: split up and reduce "ci/test-documentation.sh" Message-ID: <46b7dcdd-0c08-54ed-b8aa-22cf10d21e2f@sunshineco.com> In-Reply-To: On 4/13/22 3:51 PM, Ævar Arnfjörð Bjarmason wrote: > Change the "ci/test-documentation.sh" script to run the bash-specific > parts in as one command in the CI job itself, and to run the two "make > doc" commands at the top-level. > > It'll now be obvious from the title of the step if if we failed in the > asciidoc or asciidoctor step. s/if if/if/ > Since the "check_unignored_build_artifacts()" function is now only > used in "ci/check-unignored-build-artifacts.sh" move that function > there. > > The recipe for the job in ".github/workflows/main.yml" is now a bit > verbose because it's effectively the same job twice, with a "make > clean" in-between. It would be better for the verbosity to run it via > a matrix as done in the alternate approach in [1] does, but then we'd > sacrifice overall CPU time for the brevity. It might still be worth > doing, but let's go for this simpler approach for now. > > 1. https://lore.kernel.org/git/patch-v2-6.6-7c423c8283d-20211120T030848Z-avarab@gmail.com/ > > Signed-off-by: Ævar Arnfjörð Bjarmason