From: Tian Yuchen <cat@malon.dev>
Date: Fri, 07 Aug 2026 08:30:30 GMT
Subject: Re: [PATCH v2 1/3] environment: simplify repository config getters
Message-ID: <46b0a9fd-ce30-4110-bd9f-b315ab4a09ce@malon.dev>
In-Reply-To: <xmqqv79nkxc3.fsf@gitster.g>

On 8/7/26 00:50, Junio C Hamano wrote:
> Tian Yuchen <cat@malon.dev> writes:
> 
>> Drop unnecessary parentheses and NULL checks in repository config
>> getters.
>>
>> These getters are only used with non-NULL repositories, so the
>> extra checks do not match their current callers.
> 
> You would need to explain why it is sensible to enforce on future
> callers the same rule that current callers honor, or why it is
> unlikely that we will gain any more callers in the future (which
> would justify catering only to current callers).
> 
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
>> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
>> Signed-off-by: Tian Yuchen <cat@malon.dev>
>> ---
>>   environment.c | 18 +++++++++---------
>>   1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/environment.c b/environment.c
>> index 76ee65e62b..f5628b6758 100644
>> --- a/environment.c
>> +++ b/environment.c
>> @@ -119,23 +119,23 @@ int is_bare_repository(struct repository *repo)
>>   
>>   int repo_protect_ntfs(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->protect_ntfs :
>> -		PROTECT_NTFS_DEFAULT;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->protect_ntfs
>> +		: PROTECT_NTFS_DEFAULT;
>>   }
>>   
>>   int repo_protect_hfs(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->protect_hfs :
>> -		PROTECT_HFS_DEFAULT;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->protect_hfs
>> +		: PROTECT_HFS_DEFAULT;
>>   }
>>   
>>   int repo_ignore_case(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->ignore_case :
>> -		0;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->ignore_case
>> +		: 0;
>>   }
>>   
>>   int repo_trust_executable_bit(struct repository *repo)

I see, will change the commit message then ;)

Thanks, yuchen