From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Mon, 17 Mar 2008 19:34:39 GMT
Subject: Re: [PATCH] git-cvsserver: handle change type T
Message-ID: <46a038f90803171234m7e3f1cbfgb65311bfb64e6e0d@mail.gmail.com>
In-Reply-To: <7vve3lbwz9.fsf@gitster.siamese.dyndns.org>

On Mon, Mar 17, 2008 at 9:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
>  Martin, likes, dislikes?

Hmmm. Trying to make up my mind on this. It looks like symlink support
is broken in cvsserver, it is something we did not even consider, so I
am trying to visualise _how_ broken it is, and what it would take to

 - refuse to handle symlinks (temporarily, until we can guarantee our
handling is sane)
 - translate symlinks that are internal - hard, and probably not even
a good idea
 - handle symlinks directly - is the client safe from malicious symlinks?

I have never used symlinks with either git or cvs, so I am unsure as
to whether their handling is compatible. Do either of them perform any
sanity checks on the targetof the symlink?

cheers,



m