From: Martin Langhoff Date: Tue, 04 Sep 2007 21:02:59 GMT Subject: Re: Calculating tree nodes Message-ID: <46a038f90709041402k45d72dc6l59f93cd22b8c02e9@mail.gmail.com> In-Reply-To: <46DD7660.2030109@op5.se> On 9/5/07, Andreas Ericsson wrote: > Jon Smirl wrote: > > The > > essential part of the commit is the SHA1 list. The path names belong > > to the file objects and should be stored there. > > Sorry, but it'll take code and benchmarks to convince me this is a > good idea. Same here. But I do want to note that adding the pathname to the blob (and storing them on the combined SHA1 I assume) is broken, broken, broken. It won't support any of the great semantics that git has today. Jon: I think you need to think carefully about the key operations like diff and log on paths on projects like linux or mozilla. Even better, craft a proof-of-concept patch that shows how that'd work, and why it's faster/smaller. cheers, m