From: René Scharfe Date: Sat, 08 Sep 2007 16:18:20 GMT Subject: Re: [PATCH 1/3] Add strbuf_rtrim (to remove trailing spaces). Message-ID: <46E2CB4C.8050209@lsrfire.ath.cx> In-Reply-To: <1189252399433-git-send-email-madcoder@debian.org> Pierre Habouzit schrieb: > diff --git a/strbuf.c b/strbuf.c > index acc7fc8..565c343 100644 > --- a/strbuf.c > +++ b/strbuf.c > @@ -28,6 +28,13 @@ void strbuf_grow(struct strbuf *sb, size_t extra) { > ALLOC_GROW(sb->buf, sb->len + extra + 1, sb->alloc); > } > > +void strbuf_rtrim(struct strbuf *sb) > +{ > + while (sb->len > 0 && isspace((unsigned char)sb->buf[sb->len - 1])) > + sb->len--; > + sb->buf[sb->len] = '\0'; > +} Please use tabs instead of spaces to indent, just like you did in your other patches. :) René