From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Tue, 04 Sep 2007 15:08:54 GMT
Subject: Re: [PATCH] Functions for updating refs.
Message-ID: <46DD7506.3090503@eudaptics.com>
In-Reply-To: <Pine.LNX.4.64.0709041557590.28586@racer.site>

Johannes Schindelin schrieb:
> Hi,
> 
> On Tue, 4 Sep 2007, Johannes Sixt wrote:
> 
>> Johannes Schindelin schrieb:
>>> On Tue, 4 Sep 2007, Carlos Rica wrote:
>>>> +int update_ref_or_die(const char *action, const char *refname,
>>>> +				const unsigned char *sha1,
>>>> +				const unsigned char *oldval, int flags)
>>> Should this not be "void"?  And should it not use update_ref_or_error()?
>> It should not use *_error() directly because then it would print two error
>> messages in a row.
> 
> Well, my idea was to let _error() print the message, and just die().

How do you avoid that die() prints an error, too?

-- Hannes