From: Steven Grimm <koreth@midwinter.com>
Date: Sun, 12 Aug 2007 13:02:40 GMT
Subject: Re: --exit-code (and --quiet) broken in git-diff?
Message-ID: <46BF04F0.5020304@midwinter.com>
In-Reply-To: <85643lq99h.fsf@lola.goethe.zz>

David Kastrup wrote:
> I think I would call that a mistake.  However, I don't see that fixing
> it would actually be useful: if a pager gets called, this means that
> git-diff might die with SIGPIPE (when the user quits the pager), and
> that in turn has pretty much no meaning.  So one really needs to
> redirect the output, anyway.
>   

It does sort of make one wonder, though, if there's much point ever 
launching a pager when git-diff is run with --quiet -- it will never 
produce any output to page, so running a pager is guaranteed to always 
be a waste of cycles.

Unfortunately the pager is launched before the option processing code 
knows whether --quiet is being used or not; I'm not sure it's worth 
refactoring the pager launch code just to handle this one special case. 
(Or are there other cases where programs would want to be able to 
control the use of the pager?)

-Steve