From: Luben Tuikov <ltuikov@yahoo.com>
Date: Wed, 04 Jun 2008 22:24:03 GMT
Subject: Re: [PATCH] Avoid errors from git-rev-parse in gitweb blame
Message-ID: <469507.93901.qm@web31804.mail.mud.yahoo.com>
In-Reply-To: <7v3ant213k.fsf@gitster.siamese.dyndns.org>

--- On Tue, 6/3/08, Junio C Hamano <gitster@pobox.com> wrote:

> Another breakage is even though $full_rev^ _may_ exist
> (iow, $full_rev
> might not be the root commit), the file being blamed may
> not exist there
> (iow $full_rev might have introduced the file).  Instead of
> running
> "rev-parse $full_rev^", you would at least need
> to ask "rev-list -1
> $full_rev^ -- $path" or something from the Porcelain
> layer, but
> unfortunately this is rather expensive.

Yes, I've seen this too, but saw no advantage to bring it up
at the time.

> Because blame already almost knows if the commit the final
> blame lies on
> has a parent, it would be reasonably cheap to add that
> "parent or nothing"
> information to its --porcelain (and its --incremental)
> format if we wanted
> to.

Yes, I agree.  At the moment those "checks" are left to be
deduced by the person data-mining with blame.  (Which isn't /that/
bad.)

   Luben