From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Tue, 12 Jun 2007 17:43:25 GMT
Subject: Re: [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning
Message-ID: <466EDB3D.4070302@ramsay1.demon.co.uk>
In-Reply-To: <7vr6olh7pb.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>> ---
>>  connect.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/connect.c b/connect.c
>> index da89c9c..d4051dd 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -179,7 +179,6 @@ static int count_refspec_match(const char *pattern,
>>  	for (weak_match = match = 0; refs; refs = refs->next) {
>>  		char *name = refs->name;
>>  		int namelen = strlen(name);
>> -		int weak_match;
>>  
>>  		if (namelen < patlen ||
>>  		    memcmp(name + namelen - patlen, pattern, patlen))
> 
> This one is an obvious bug.  

Indeed ;-)
Also, I'm guessing it does not bring your machine down like a house of cards.

... Essentially, it makes weak matches
> ignored.  Unfortunately this has been hiding a larger bug in the
> caller of this function.  I am refactoring the mess right now.
> 
Great. Hopefully it will also address the cygwin issue.

ATB

Ramsay Jones