From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Fri, 01 Jun 2007 07:56:12 GMT
Subject: Re: [PATCH] Add basic test-script for git-submodule
Message-ID: <465FD11C.6B1D5172@eudaptics.com>
In-Reply-To: <op.ts8d71b89pspc6@localhost>

Lars Hjemli wrote:
> +test_expect_success 'status should only print one line' '
> +       lines=$(git-submodule status | wc -l)

&& is missing.

> +       test "$lines" = "1"

Please don't put output of wc in quotes because some versions of wc emit
padding:

	test $lines = 1

(without the quotes around 1 - like in other test scripts).

-- Hannes