From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Tue, 17 Apr 2007 10:41:56 GMT
Subject: Re: [PATCH 2/2] Add keyword unexpansion support to convert.c
Message-ID: <4624A474.77756C86@eudaptics.com>
In-Reply-To: <200704171041.46176.andyparkins@gmail.com>

Andy Parkins wrote:
>         switch (git_path_check_crlf(path)) {
>         case 0:
> -               return 0;
> +               changes += 0;
>         case 1:
> -               return forcecrlf_to_git(path, bufp, sizep);
> +               changes += forcecrlf_to_git(path, bufp, sizep);
>         default:
> -               return autocrlf_to_git(path, bufp, sizep);
> +               changes += autocrlf_to_git(path, bufp, sizep);
> +       }
> +
> +       switch (git_path_check_keyword(path)) {
> +       case 0:
> +               changes += 0;
> +       case 1:
> +               changes += keyword_unexpand_git(path, bufp, sizep);
>         }

I think there are 'break's missing all along the way.

-- Hannes