From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 30 Dec 2025 14:33:19 GMT
Subject: Re: What's cooking in git.git (Dec 2025, #09)
Message-ID: <460f1f96-4236-4d19-bdfa-6c86bad811c5@app.fastmail.com>
In-Reply-To: <xmqqa4z0f5dq.fsf@gitster.g>

On Tue, Dec 30, 2025, at 14:47, Junio C Hamano wrote:
> * kh/replay-invalid-onto-advance (2025-12-22) 2 commits
>  - t3650: add more regression tests for failure conditions
>  - replay: die descriptively when invalid commit-ish
>
>  Test coverage of "git replay" has been improved.

The main change is a better error message when you give a bad argument
to `--onto`.  The improved test coverage is secondary but related since
the coverage for simple die conditions (like bad `--onto` argument) is
poor. (Like the mistake that you pointed out;[1] I was about to make the
error message for `--advance` slightly worse. But the test for “argument
to --advance must be a reference” will make it harder for me to make
that mistake in the future.)

The second version is coming now.

🔗 1: https://lore.kernel.org/git/xmqqpl85pb7k.fsf@gitster.g/

>
>  Expecting a rework on the bottom patch.
>  source: <CV_replay_die_descr.13f@msgid.xyz>